Bug 225591

Summary: REGRESSION(r275515): wpt/quirks/blocks-ignore-line-height.html
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: http://wpt.live/quirks/blocks-ignore-line-height.html
See Also: https://bugs.webkit.org/show_bug.cgi?id=220148
Attachments:
Description Flags
Test reduction
none
Patch
none
Patch none

Description Sam Sneddon [:gsnedders] 2021-05-10 05:20:46 PDT 
Via STP124 regressing this on wpt.fyi.

Quick glance makes it look like LFC is applying the standards-mode behaviour in all modes.
Comment 1 zalan 2021-05-10 08:25:09 PDT 
(In reply to Sam Sneddon [:gsnedders] from comment #0)
> Via STP124 regressing this on wpt.fyi.
> 
> Quick glance makes it look like LFC is applying the standards-mode behaviour
> in all modes.
Indeed, this looks like a standards vs. quirk mode confusion.
Comment 2 zalan 2021-05-10 10:00:32 PDT 
Created attachment 428179 [details]
Test reduction

Actually this looks to be about resolving the "line-height: <number>" value in quirks mode when the root inline box is empty and the inline box (<span>) has different font-size value as the containing block.
Comment 3 Radar WebKit Bug Importer 2021-05-10 10:40:33 PDT 
<rdar://problem/77766308>
Comment 4 zalan 2021-05-10 20:34:22 PDT 
Created attachment 428242 [details]
Patch
Comment 5 zalan 2021-05-11 06:55:27 PDT 
Created attachment 428271 [details]
Patch
Comment 6 EWS 2021-05-11 08:33:21 PDT 
Committed r277325 (237584@main): <https://commits.webkit.org/237584@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428271 [details].