| Summary: | Remove calls to the String::toInt family of functions from JavaScriptCore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | JavaScriptCore | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2021-05-08 18:23:29 PDT
Created attachment 428105 [details]
Patch
Style checker is complaining that I am using the word fuzzer in the change log. This is very silly since it’s in the file name of a file I am modifying. Comment on attachment 428105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review > Source/JavaScriptCore/ChangeLog:10 > + (Inspector::parseLocation): Use parseIntegerAllowingTrailingJunk<uintptr_t> instead of > + String::toIntPtr. Why the change from intptr_t to uintptr_t here? Comment on attachment 428105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review >> Source/JavaScriptCore/ChangeLog:10 >> + String::toIntPtr. > > Why the change from intptr_t to uintptr_t here? Unintentional. I will change it back. Comment on attachment 428105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review >>> Source/JavaScriptCore/ChangeLog:10 >>> + String::toIntPtr. >> >> Why the change from intptr_t to uintptr_t here? > > Unintentional. I will change it back. Actually, the type is JSC::SourceID, not intptr_t and not uintptr_t either. I am changing to that. Committed r277240 (237509@main): <https://commits.webkit.org/237509@main> |