Summary: | [ BigSur Debug wk2 ARM64 ] imported/w3c/web-platform-tests/webrtc-encoded-transform/sframe-transform-readable.html is flaky crashing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robert Jenner <jenner> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, benjamin, calvaris, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=225528 | ||||||||||
Attachments: |
|
Description
Robert Jenner
2021-05-07 12:16:30 PDT
Created attachment 428021 [details]
Full crashlog
attaching full crashlog to bug.
This only appears to be occurring on Apple Silicon Macs. As such, I cannot reproduce these failures because I do not have access to said system type. Updated test expectations to Pass Crash here: https://trac.webkit.org/changeset/277302/webkit This seems like a ReadableStream issue at a first glance, despite crashing in JSC. We are hitting @assert(@readableStreamDefaultControllerCanCloseOrEnqueue(controller)); 07:01:32.558 2397 ASSERTION FAILED: JS assertion failed at line 1 in: 07:01:32.558 2397 function (controller, chunk) 07:01:32.559 2397 { 07:01:32.559 2397 "use strict"; 07:01:32.559 2397 07:01:32.559 2397 const stream = @getByIdDirectPrivate(controller, "controlledReadableStream"); 07:01:32.559 2397 @assert(@readableStreamDefaultControllerCanCloseOrEnqueue(controller)); 07:01:32.559 2397 07:01:32.559 2397 if (@isReadableStreamLocked(stream) && @getByIdDirectPrivate(@getByIdDirectPrivate(stream, "reader"), "readRequests").length) { 07:01:32.559 2397 @readableStreamFulfillReadRequest(stream, chunk, false); 07:01:32.559 2397 @readableStreamDefaultControllerCallPullIfNeeded(controller); 07:01:32.559 2397 return; 07:01:32.559 2397 } 07:01:32.559 2397 07:01:32.559 2397 try { 07:01:32.559 2397 let chunkSize = 1; 07:01:32.559 2397 if (@getByIdDirectPrivate(controller, "strategy").size !== @undefined) 07:01:32.559 2397 chunkSize = @getByIdDirectPrivate(controller, "strategy").size(chunk); 07:01:32.559 2397 @enqueueValueWithSize(@getByIdDirectPrivate(controller, "queue"), chunk, chunkSize); 07:01:32.559 2397 } 07:01:32.559 2397 catch(error) { 07:01:32.559 2397 @readableStreamDefaultControllerError(controller, error); 07:01:32.559 2397 throw error; 07:01:32.559 2397 } 07:01:32.559 2397 @readableStreamDefaultControllerCallPullIfNeeded(controller); 07:01:32.559 2397 } 07:01:32.559 2397 Probably from running imported/w3c/web-platform-tests/webrtc-encoded-transform/sframe-transform-in-worker.https.html Created attachment 428821 [details]
Patch
Created attachment 428827 [details]
Patch
Committed r277589 (237814@main): <https://commits.webkit.org/237814@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428827 [details]. |