Summary: | [iOS] fix inconsistency around the meaning of `rate` and `defaultPlaybackRate` between WebKit and AVKit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | New Bugs | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, hi, peng.liu6, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=228939 | ||||||||
Attachments: |
|
Description
Devin Rousso
2021-05-07 11:52:58 PDT
Created attachment 428016 [details]
Patch
Comment on attachment 428016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428016&action=review > Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:130 > + [m_playerController setRate:isPlaying ? playbackRate : 0.]; Is this change intended? > Source/WebCore/platform/ios/WebAVPlayerController.mm:201 > + // ending scanning, instead using the `playbackRate` is used in all other cases, including when Nit. s/instead using/instead/ Comment on attachment 428016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428016&action=review >> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:130 >> + [m_playerController setRate:isPlaying ? playbackRate : 0.]; > > Is this change intended? Yes. This is because ultimately we want the `rate` to be the source of truth, so we want to set it last. >> Source/WebCore/platform/ios/WebAVPlayerController.mm:201 >> + // ending scanning, instead using the `playbackRate` is used in all other cases, including when > > Nit. > s/instead using/instead/ Oops, will change :) Created attachment 428025 [details]
Patch
Committed r277203 (237475@main): <https://commits.webkit.org/237475@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428025 [details]. |