Bug 225532 – [iOS] fix inconsistency around the meaning of `rate` and `defaultPlaybackRate` between WebKit and AVKit

• Component: New Bugs
• Status: RESOLVED FIXED

[Devin Rousso]

In AVKit, the `defaultPlaybackRate` is used when playback starts, such as resuming after pausing.

In WebKit, however, `defaultPlaybackRate` is only used when first loading and after ending scanning, instead using the `playbackRate` is used in all other cases, including when resuming after pausing.

[Devin Rousso]

<rdar://problem/77629276>

[Devin Rousso]

Created attachment 428016 [details]
Patch

[Peng Liu]

Comment on attachment 428016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428016&action=review

> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:130
> +    [m_playerController setRate:isPlaying ? playbackRate : 0.];

Is this change intended?

> Source/WebCore/platform/ios/WebAVPlayerController.mm:201
> +    // ending scanning, instead using the `playbackRate` is used in all other cases, including when

Nit.
s/instead using/instead/

[Devin Rousso]

Comment on attachment 428016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428016&action=review

>> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:130
>> +    [m_playerController setRate:isPlaying ? playbackRate : 0.];
> 
> Is this change intended?

Yes.  This is because ultimately we want the `rate` to be the source of truth, so we want to set it last.

>> Source/WebCore/platform/ios/WebAVPlayerController.mm:201
>> +    // ending scanning, instead using the `playbackRate` is used in all other cases, including when
> 
> Nit.
> s/instead using/instead/

Oops, will change :)

[Devin Rousso]

Created attachment 428025 [details]
Patch

[EWS]

Committed r277203 (237475@main): <https://commits.webkit.org/237475@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428025 [details].