| Summary: | [GTK] Use always async scrolling in accelerated compositing mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | REOPENED --- | ||||||
| Severity: | Normal | CC: | alex, berto, bugs-noreply, cmarcelo, commit-queue, ews-watchlist, gustavo, gyuyoung.kim, Hironori.Fujii, luiz, ryuan.choi, sergio, zdobersek, zeno | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 225740 | ||||||
| Bug Blocks: | 245783 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2021-05-07 07:48:27 PDT
Created attachment 427996 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 427996 [details] Patch Honestly speaking I prefer the approach doing that in WebPage without platfrom #if (attachment#420247 [details]) rather than in DrawingAreaCoordinatedGraphics with #if PLATFORM(GTK). But, I don't have time to Bug 225512 now. And, I admit it's a good idea not changing Cocoa-port code for this. *** Bug 221067 has been marked as a duplicate of this bug. *** (In reply to Fujii Hironori from comment #3) > Comment on attachment 427996 [details] > Patch > > Honestly speaking I prefer the approach doing that in WebPage without > platfrom #if (attachment#420247 [details]) rather than in > DrawingAreaCoordinatedGraphics with #if PLATFORM(GTK). > But, I don't have time to Bug 225512 now. And, I admit it's a good idea not > changing Cocoa-port code for this. Problem is that enter/exit in WebPage doesn't seem to be balanced, enter can be called more than once, and I've seen also exit/enter calls that don't really exit and enter the AC mode. That doesn't happen with the enter/exit calls in DrawingArea. Committed r277258 (237527@main): <https://commits.webkit.org/237527@main> Re-opened since this is blocked by bug 225740 This is not so easy in the end. with the patch we are now causing that pages enter in Ac mode when there's an iframe, for example, because async frame scrolling is enabled. I need to investigate this further. Chris and me are working in checking some regressions since I activated the async mode in WPE testing by default (bug 224596), the problem can be related. Can you send more information of the failures you are seeing? See https://bugs.webkit.org/show_bug.cgi?id=225644. But the test failure is not the only issue I've noticed, as I said before. |