Bug 225512 – [GTK] Use always async scrolling in accelerated compositing mode

• Component: WebKitGTK
• Status: REOPENED

[Carlos Garcia Campos]

We currently use async scrolling only when the hardware acceleration policy is set for always, but not when entering accelerating compositing mode in ondemand policy.

[Carlos Garcia Campos]

Created attachment 427996 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Fujii Hironori]

Comment on attachment 427996 [details]
Patch

Honestly speaking I prefer the approach doing that in WebPage without platfrom #if (attachment#420247 [details]) rather than in DrawingAreaCoordinatedGraphics with #if PLATFORM(GTK).
But, I don't have time to Bug 225512 now. And, I admit it's a good idea not changing Cocoa-port code for this.

[Fujii Hironori]

*** Bug 221067 has been marked as a duplicate of this bug. ***

[Carlos Garcia Campos]

(In reply to Fujii Hironori from comment #3)
> Comment on attachment 427996 [details]
> Patch
> 
> Honestly speaking I prefer the approach doing that in WebPage without
> platfrom #if (attachment#420247 [details]) rather than in
> DrawingAreaCoordinatedGraphics with #if PLATFORM(GTK).
> But, I don't have time to Bug 225512 now. And, I admit it's a good idea not
> changing Cocoa-port code for this.

Problem is that enter/exit in WebPage doesn't seem to be balanced, enter can be called more than once, and I've seen also exit/enter calls that don't really exit and enter the AC mode. That doesn't happen with the enter/exit calls in DrawingArea.

[Carlos Garcia Campos]

Committed r277258 (237527@main): <https://commits.webkit.org/237527@main>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 225740

[Carlos Garcia Campos]

This is not so easy in the end. with the patch we are now causing that pages enter in Ac mode when there's an iframe, for example, because async frame scrolling is enabled. I need to investigate this further.

[Alejandro G. Castro]

Chris and me are working in checking some regressions since I activated the async mode in WPE testing by default (bug 224596), the problem can be related. Can you send more information of the failures you are seeing?

[Carlos Garcia Campos]

See https://bugs.webkit.org/show_bug.cgi?id=225644. But the test failure is not the only issue I've noticed, as I said before.