Bug 225503

Summary: [WPE] TestWebExtensions web-process-crashed is flaky failing after latest WPE libs update
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WPE WebKitAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cgarcia, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225358
https://github.com/Igalia/WPEBackend-fdo/pull/158
Attachments:
Description Flags
[fast-cq] Patch none

Description Lauro Moura 2021-05-06 21:27:32 PDT
/WPE/TestWebExtensions
    /webkit/WebKitWebView/web-process-crashed

First failure: 237336@main (r277020) in build: https://build.webkit.org/#/builders/40/builds/1542

libWPE and WPE-backend FDO updated respectively to 1.10 and 1.9.91 in 237333 (r277017), and picked up first by the build above.

Could not reproduce the issue with SDK version r276635 locally but SDK version r277017 indeed it's flaky.

Log:

TEST: WebKitBuild/WPE/Release/bin/TestWebKitAPI/WPE/TestWebExtensions...
  /webkit/WebKitWebView/web-process-crashed:                          FAIL
WPE-FDO-FATAL-WARNING: Instance::dispatchFrameCallbacks(): Cannot find surface with bridgeId 1 in view backend map. Probably the associated surface is gone due to a premature exit in the client side

(WebKitBuild/WPE/Release/bin/TestWebKitAPI/WPE/TestWebExtensions:14): WPE-FDO-WARNING **: 21:25:38.534: Instance::dispatchFrameCallbacks(): Cannot find surface with bridgeId 1 in view backend map. Probably the associated surface is gone due to a premature exit in the client side

Unexpected failures (1)
    WebKitBuild/WPE/Release/bin/TestWebKitAPI/WPE/TestWebExtensions
        /webkit/WebKitWebView/web-process-crashed
Comment 1 Lauro Moura 2021-05-06 21:41:27 PDT
Gardened in r277157
Comment 2 Adrian Perez 2021-05-07 00:09:43 PDT
The crash here I suspect is caused by the test being run with
“G_DEBUG=fatal-warnings” but I don't remember if the test harness
does that. At any rate, we are working on plugging a regression
in https://github.com/Igalia/WPEBackend-fdo/pull/158 and once
that is solved we should remove this warning from WPEBackend-fdo.
Pablo Saavedra and myself are actively working on this but progress
has been slow so I cannot give you a certain ETA… maybe we should
consider downgrading WPEBackend-fdo back in the meantime.
Comment 3 Philippe Normand 2021-05-07 00:59:59 PDT
Created attachment 427978 [details]
[fast-cq] Patch
Comment 4 EWS 2021-05-07 01:47:33 PDT
Committed r277165 (237451@main): <https://commits.webkit.org/237451@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427978 [details].
Comment 5 Philippe Normand 2021-05-07 02:42:18 PDT
(In reply to Lauro Moura from comment #1)
> Gardened in r277157

SDK r277166 is deployed but I haven't updated test expectations yet.
Comment 6 Philippe Normand 2021-05-07 03:02:36 PDT
(In reply to Philippe Normand from comment #5)
> (In reply to Lauro Moura from comment #1)
> > Gardened in r277157
> 
> SDK r277166 is deployed but I haven't updated test expectations yet.

Unflagged in r277167.