Bug 225445

Summary: Re-import css/css-contain WPT
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, rbuis, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 225402    
Attachments:
Description Flags
Patch
none
Patch none

Description Tim Nguyen (:ntim) 2021-05-06 03:25:45 PDT
some wpt to reimport
Comment 1 Tim Nguyen (:ntim) 2021-05-06 03:38:11 PDT
Created attachment 427865 [details]
Patch
Comment 2 Tim Nguyen (:ntim) 2021-05-06 04:15:57 PDT
Created attachment 427867 [details]
Patch
Comment 3 Rob Buis 2021-05-06 05:30:24 PDT
Comment on attachment 427867 [details]
Patch

LGTM. BTW we usually state the git hash where the import is based on in the Changelog.
Comment 4 Tim Nguyen (:ntim) 2021-05-06 05:41:59 PDT
Thanks! I don't have the exact hash, but I'll keep that in mind next time.

My guess would be around this one: https://github.com/web-platform-tests/wpt/commit/ee1e6f06ad467fa666ff76af9f45a1dbe73f3ebb#diff-36e64f19f57a05c8cd5b6bf7eff72703b4bbab19def7832eb4e686e7fa482eef
Comment 5 EWS 2021-05-06 05:58:43 PDT
Committed r277084 (237387@main): <https://commits.webkit.org/237387@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427867 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-06 05:59:12 PDT
<rdar://problem/77603833>