Bug 225429

Summary: Fix potential races in AppleLanguagesTest.UpdateAppleLanguages API test
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, darin, ggaren, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222825
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-05-05 18:40:36 PDT
Fix potential race in AppleLanguagesTest.UpdateAppleLanguages API test.
Attachments
Patch (3.32 KB, patch)
2021-05-05 18:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2021-05-05 19:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.48 KB, patch)
2021-05-05 19:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.72 KB, patch)
2021-05-05 19:45 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.41 KB, patch)
2021-05-05 20:17 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.40 KB, patch)
2021-05-10 08:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-05 18:45:36 PDT
Created attachment 427837 [details] Patch
Chris Dumez
Comment 2 2021-05-05 19:19:18 PDT
Created attachment 427839 [details] Patch
Chris Dumez
Comment 3 2021-05-05 19:22:20 PDT
Created attachment 427840 [details] Patch
Chris Dumez
Comment 4 2021-05-05 19:45:19 PDT
Created attachment 427841 [details] Patch
Chris Dumez
Comment 5 2021-05-05 20:17:53 PDT
Created attachment 427845 [details] Patch
Alex Christensen
Comment 6 2021-05-05 20:24:29 PDT
Comment on attachment 427845 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427845&action=review > Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:61 > // FIXME: This test is currently disabled on Apple Silicon because it times out there (https://bugs.webkit.org/show_bug.cgi?id=222619). Is it possible this is fixed too?
Chris Dumez
Comment 7 2021-05-05 20:29:26 PDT
(In reply to Alex Christensen from comment #6) > Comment on attachment 427845 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427845&action=review > > > Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:61 > > // FIXME: This test is currently disabled on Apple Silicon because it times out there (https://bugs.webkit.org/show_bug.cgi?id=222619). > > Is it possible this is fixed too? Well this is what I am trying to fix but so far no success.
Chris Dumez
Comment 8 2021-05-05 20:30:20 PDT
(In reply to Chris Dumez from comment #7) > (In reply to Alex Christensen from comment #6) > > Comment on attachment 427845 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=427845&action=review > > > > > Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:61 > > > // FIXME: This test is currently disabled on Apple Silicon because it times out there (https://bugs.webkit.org/show_bug.cgi?id=222619). > > > > Is it possible this is fixed too? > > Well this is what I am trying to fix but so far no success. That is why I related the bugs but did not claim to have fixed the other one.
Chris Dumez
Comment 9 2021-05-10 08:38:00 PDT
Created attachment 428172 [details] Patch
EWS
Comment 10 2021-05-10 09:38:09 PDT
Committed r277267 (237534@main): <https://commits.webkit.org/237534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428172 [details].
Radar WebKit Bug Importer
Comment 11 2021-05-10 09:39:17 PDT
<rdar://problem/77752526>
Note You need to log in before you can comment on or make changes to this bug.