Bug 225415

Summary: [build.webkit.org] Add a build step to set appropriate permissions on uploaded test results
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dewei_zhu, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
[fast-cq] Patch none

Description Aakash Jain 2021-05-05 14:08:06 PDT
Add a build step to set appropriate permissions on uploaded test results on build.webkit.org

See rdar://74200562
Comment 1 Aakash Jain 2021-05-05 14:10:12 PDT
Created attachment 427804 [details]
Patch
Comment 2 dewei_zhu 2021-05-05 14:26:04 PDT
Comment on attachment 427804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427804&action=review

> Tools/CISupport/build-webkit-org/steps.py:1137
> +        kwargs['command'] = ['chmod', 'a+rx', resultDirectory]

Do we really need 'x' bit for the result file?
Comment 3 Aakash Jain 2021-05-05 14:43:42 PDT
(In reply to dewei_zhu from comment #2)
> Do we really need 'x' bit for the result file?
Yes, since this is for the directory, and we want to allow the directory browsing.

Also, this step is already running on build.webkit.org for a while, e.g. https://build.webkit.org/#/builders/70/builds/200
Comment 4 dewei_zhu 2021-05-05 14:47:32 PDT
Comment on attachment 427804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427804&action=review

r=me

>> Tools/CISupport/build-webkit-org/steps.py:1137
>> +        kwargs['command'] = ['chmod', 'a+rx', resultDirectory]
> 
> Do we really need 'x' bit for the result file?

Discussed in person, it looks like we do need it for listing directory.
Comment 5 Aakash Jain 2021-05-05 14:49:34 PDT
Created attachment 427811 [details]
[fast-cq] Patch
Comment 6 EWS 2021-05-05 14:52:45 PDT
Committed r277043 (237355@main): <https://commits.webkit.org/237355@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427811 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-05 14:53:16 PDT
<rdar://problem/77576905>