Summary: | Forbid further execution in jsc shell if execution is terminated. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2021-05-05 13:16:09 PDT
Created attachment 427797 [details]
propose patch.
Comment on attachment 427797 [details] propose patch. View in context: https://bugs.webkit.org/attachment.cgi?id=427797&action=review r=me with a suggested change. > Source/JavaScriptCore/runtime/VM.h:345 > + void setExecutionForbidden(bool value) { m_executionForbidden = value; } Seem like we only want to go from "execution allowed", e.g. m_executionForbidden == false, to "execution forbidden", e.g. m_executionForbidden == true. I suggest we eliminate the argument to setExecutionForbidden() and have it always set m_executionForbidden to true. (In reply to Michael Saboff from comment #2) > Comment on attachment 427797 [details] > propose patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427797&action=review > > r=me with a suggested change. > > > Source/JavaScriptCore/runtime/VM.h:345 > > + void setExecutionForbidden(bool value) { m_executionForbidden = value; } > > Seem like we only want to go from "execution allowed", e.g. > m_executionForbidden == false, to "execution forbidden", e.g. > m_executionForbidden == true. I suggest we eliminate the argument to > setExecutionForbidden() and have it always set m_executionForbidden to true. I agree. That's probably the better approach until we find evidence to the contrary. Thanks for the review. I've made the suggested change. Landed in r277094: <http://trac.webkit.org/r277094>. |