Bug 225379

Summary: [WPE] [Debug] ASSERTION FAILED: !m_adoptionIsRequired in several WebXR tests
Product: WebKit Reporter: Diego Pino <dpino>
Component: New BugsAssignee: Diego Pino <dpino>
Status: RESOLVED FIXED    
Severity: Normal CC: ifernandez, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225025
Attachments:
Description Flags
[fast-cq] Patch none

Description Diego Pino 2021-05-04 19:30:33 PDT 
Several WebXR tests are crashing in WPE Debug with the following assertion error:

STDERR: ASSERTION FAILED: !m_adoptionIsRequired
STDERR: WTF/Headers/wtf/RefCounted.h(47) : void WTF::RefCountedBase::ref() const
STDERR: 1   0x7f506c71f5c1 WTFCrash
STDERR: 2   0x7f5065065845 WTF::CrashOnOverflow::overflowed()
STDERR: 3   0x7f5065077bc9 WTF::RefCountedBase::ref() const
STDERR: 4   0x7f50672802c3 WTF::Ref<WebCore::WebXRSession, WTF::RawPtrTraits<WebCore::WebXRSession> >::Ref(WebCore::WebXRSession&)
STDERR: 5   0x7f5067941e6e WebCore::WebXRSession::WebXRSession(WebCore::Document&, WebCore::WebXRSystem&, PlatformXR::SessionMode, PlatformXR::Device&, WTF::Vector<PlatformXR::ReferenceSpaceType, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)
STDERR: 6   0x7f5067941d74 WebCore::WebXRSession::create(WebCore::Document&, WebCore::WebXRSystem&, PlatformXR::SessionMode, PlatformXR::Device&, WTF::Vector<PlatformXR::ReferenceSpaceType, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)
STDERR: 7   0x7f5067957fa1 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x104eafa1) [0x7f5067957fa1]
STDERR: 8   0x7f5067958135 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x104eb135) [0x7f5067958135]
STDERR: 9   0x7f506795ab44 WTF::Function<void (PlatformXR::Device*)>::operator()(PlatformXR::Device*) const
STDERR: 10  0x7f50679596f7 WTF::CompletionHandler<void (PlatformXR::Device*)>::operator()(PlatformXR::Device*)
STDERR: 11  0x7f506795409d /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x104e709d) [0x7f506795409d]
STDERR: 12  0x7f5067958178 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0x104eb178) [0x7f5067958178]
STDERR: 13  0x7f50650c4b63 WTF::Function<void ()>::operator()() const
STDERR: 14  0x7f50650c4ad9 WTF::CompletionHandler<void ()>::operator()()
STDERR: 15  0x7f5067953f11 WebCore::WebXRSystem::ensureImmersiveXRDeviceIsSelected(WTF::CompletionHandler<void ()>&&)
STDERR: 16  0x7f5067954151 WebCore::WebXRSystem::obtainCurrentDevice(PlatformXR::SessionMode, WTF::Vector<JSC::JSValue, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::Vector<JSC::JSValue, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WTF::CompletionHandler<void (PlatformXR::Device*)>&&)
STDERR: 17  0x7f5067954efe WebCore::WebXRSystem::requestSession(WebCore::Document&, PlatformXR::SessionMode, WebCore::XRSessionInit const&, WebCore::DOMPromiseDeferred<WebCore::IDLInterface<WebCore::WebXRSession> >&&)
STDERR: 18  0x7f506726dd86 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe00d86) [0x7f506726dd86]
STDERR: 19  0x7f5067273ac0 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe06ac0) [0x7f5067273ac0]
STDERR: 20  0x7f506726e203 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe01203) [0x7f506726e203]
STDERR: 21  0x7f5067273c4a /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe06c4a) [0x7f5067273c4a]
STDERR: 22  0x7f506727562d /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe0862d) [0x7f506727562d]
STDERR: 23  0x7f5067273c82 /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe06c82) [0x7f5067273c82]
STDERR: 24  0x7f506726e28f /app/webkit/WebKitBuild/Debug/lib/libWPEWebKit-1.1.so.0(+0xfe0128f) [0x7f506726e28f]
STDERR: 25  0x7f5011aff1d8 [0x7f5011aff1d8]
STDERR: LEAK: 1 WebPageProxy

The tests that are crashing are the following:

  http/wpt/webxr/xrSession_end_device_reports_shutdown.https.html
  http/wpt/webxr/xrSession_ended_by_system.https.html
  http/wpt/webxr/xrSession_reject_multiple_end.https.html
  imported/w3c/web-platform-tests/webxr/ar-module/idlharness.https.window.html
  imported/w3c/web-platform-tests/webxr/ar-module/xrDevice_requestSession_immersive-ar.https.html
  imported/w3c/web-platform-tests/webxr/events_input_source_recreation.https.html
  imported/w3c/web-platform-tests/webxr/events_input_sources_change.https.html
  imported/w3c/web-platform-tests/webxr/events_session_select.https.html
  imported/w3c/web-platform-tests/webxr/events_session_select_subframe.https.html
  imported/w3c/web-platform-tests/webxr/events_session_squeeze.https.html
  imported/w3c/web-platform-tests/webxr/getInputPose_handedness.https.html
  imported/w3c/web-platform-tests/webxr/getViewerPose_emulatedPosition.https.html
  imported/w3c/web-platform-tests/webxr/idlharness.https.window.html
  imported/w3c/web-platform-tests/webxr/navigator_xr_sameObject.https.html
  imported/w3c/web-platform-tests/webxr/render_state_update.https.html
  imported/w3c/web-platform-tests/webxr/render_state_vertical_fov_immersive.https.html
  imported/w3c/web-platform-tests/webxr/xrBoundedReferenceSpace_updates.https.html
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https.html
  imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html
Comment 2 Diego Pino 2021-05-04 19:46:24 PDT 
Tests gardened in r277000.
Comment 3 Imanol Fernandez 2021-05-05 01:03:15 PDT 
Related to bug 225025
Comment 4 Sergio Villar Senin 2021-06-23 08:55:23 PDT 
Diego could you verify that the tests are passing now on Debug?
Comment 5 Diego Pino 2022-01-02 18:19:17 PST 
Created attachment 448198 [details]
[fast-cq] Patch
Comment 6 Diego Pino 2022-01-02 18:20:33 PST 
Right, these tests are no longer crashing in WPE Debug.

Added patch to remove tests failures from test expectations.
Comment 7 EWS 2022-01-02 18:23:54 PST 
Committed r287526 (245661@main): <https://commits.webkit.org/245661@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448198 [details].
Comment 8 Radar WebKit Bug Importer 2022-01-02 18:24:18 PST 
<rdar://problem/87055746>