Bug 225372

Summary:

[ BigSur Release ] TestWebKitAPI.IndexedDB.KillWebProcessWithOpenConnection is a constant failure

Product:

WebKit

Reporter:

Robert Jenner <jenner>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Robert Jenner 2021-05-04 16:43:21 PDT

TestWebKitAPI.IndexedDB.KillWebProcessWithOpenConnection

is a constantly failing API on BigSur Release.

HISTORY:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.IndexedDB.KillWebProcessWithOpenConnection

 /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:129
        Expected equality of these values:
          @"Open Succeeded"
            Which is: "Open Succeeded"
          string3.get()
            Which is: "Open Failed"

Comment 1 Radar WebKit Bug Importer 2021-05-04 16:43:43 PDT

<rdar://problem/77532291>

Comment 2 Sihui Liu 2021-05-12 13:13:07 PDT

Created attachment 428408 [details]
Patch

Comment 3 Chris Dumez 2021-05-12 13:16:46 PDT

Comment on attachment 428408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428408&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html:3
> +var db;

Why this?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html:7
> +    db = event.target.result;

why not use var here?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:41
> +static bool readyToContinue;

You don't need a global here.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:111
> +    readyToContinue = false;

__block bool readyToContinue = false;

Comment 4 Sihui Liu 2021-05-12 13:40:34 PDT

Comment on attachment 428408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428408&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html:7
>> +    db = event.target.result;
> 
> why not use var here?

Left for testing. Will move it here.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:41
>> +static bool readyToContinue;
> 
> You don't need a global here.

Will remove.

Comment 5 Sihui Liu 2021-05-12 13:40:55 PDT

Created attachment 428412 [details]
Patch for landing

Comment 6 EWS 2021-05-12 14:56:20 PDT

Committed r277392 (237648@main): <https://commits.webkit.org/237648@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428412 [details].

Comment 7 Chris Dumez 2021-05-24 15:04:06 PDT

Open Failed: UnknownError: Error creating or migrating Records table in database

Comment 8 Sihui Liu 2021-05-25 08:36:42 PDT

(In reply to Chris Dumez from comment #7)
> Open Failed: UnknownError: Error creating or migrating Records table in
> database

Yes, this is not fixed so I filed https://bugs.webkit.org/show_bug.cgi?id=226124. Can you take a look?

Comment 9 Ryan Haddad 2021-05-26 11:33:04 PDT

Current output:

    TestWebKitAPI.IndexedDB.KillWebProcessWithOpenConnection
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:134
        Expected equality of these values:
          @"Open Succeeded"
            Which is: "Open Succeeded"
          string3.get()
            Which is: "Open Failed: UnknownError: Error creating new Records table (%i) - %s5database is locked"

https://build.webkit.org/#/builders/105/builds/1474/steps/11/logs/stdio

Comment 10 Ryan Haddad 2021-06-04 13:42:31 PDT

This appears to have been resolved by <https://commits.webkit.org/238469@main>.