Summary: | [webkitscmpy] Scope classes used in TaskPool to object | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, dewei_zhu, slewis, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=225221 | ||||||
Attachments: |
|
Description
Jonathan Bedard
2021-05-04 10:41:11 PDT
Created attachment 427685 [details]
Patch
Comment on attachment 427685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427685&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:256 > + cls.queue = queue Is this used anywhere other than `cls.queue = None`? Comment on attachment 427685 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427685&action=review >> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:256 >> + cls.queue = queue > > Is this used anywhere other than `cls.queue = None`? Not yet. The motivation for this is to allow worker processes to pass messages to their parent explicitly. This is particularly helpful when running test suites, where we may be able to partially report results to our parent process before finishing the entirety of our shard. Comment on attachment 427685 [details]
Patch
r=me
Committed r276997 (237317@main): <https://commits.webkit.org/237317@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427685 [details]. |