Bug 225337

Summary: Don't iterate NetworkProcessProxy::m_websiteDataStores
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2021-05-03 16:53:15 PDT
Don't iterate NetworkProcessProxy::m_websiteDataStores
Comment 1 Alex Christensen 2021-05-03 16:58:17 PDT
Created attachment 427620 [details]
Patch
Comment 2 Alex Christensen 2021-05-03 16:58:20 PDT
<rdar://problem/77233103>
Comment 3 Chris Dumez 2021-05-03 17:14:20 PDT
Comment on attachment 427620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427620&action=review

> Source/WTF/ChangeLog:9
> +        * wtf/Vector.h:

Could you please explain what these changes in WTF are about?

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:320
> +        websiteDataStore.get().networkProcessDidTerminate(*this);

can we use -> instead of .get()?
Comment 4 Alex Christensen 2021-05-03 17:20:52 PDT
Created attachment 427626 [details]
Patch
Comment 5 Geoffrey Garen 2021-05-03 20:25:24 PDT
Comment on attachment 427626 [details]
Patch

r=me
Comment 6 EWS 2021-05-04 11:51:33 PDT
Committed r276974 (237303@main): <https://commits.webkit.org/237303@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427626 [details].