Summary: | Add Data Call ICs that don't repatch and use them in the baseline JIT | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||||||||||||||||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, sam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=225793 | ||||||||||||||||||||||||||||
Attachments: |
|
Description
Saam Barati
2021-05-03 12:00:32 PDT
Created attachment 428329 [details]
WIP
Created attachment 428441 [details]
WIP
Still need to implement 32-bit, but let's see how x86_64 does
Created attachment 428444 [details]
WIP
Created attachment 428445 [details]
WIP
Created attachment 428525 [details]
WIP
Created attachment 428533 [details]
WIP
rebased, the patch should apply to ToT now.
Created attachment 428535 [details]
WIP
Created attachment 428541 [details]
WIP
Created attachment 428581 [details]
patch
Created attachment 428582 [details]
patch
Comment on attachment 428582 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=428582&action=review > Source/JavaScriptCore/jit/JITCall32_64.cpp:306 > + if (opcodeID == op_tail_call || opcodeID == op_tail_call_varargs || opcodeID == op_tail_call_forward_arguments) lol, this should not be here... I think this is the 32-bit crashes Created attachment 428638 [details]
patch
Comment on attachment 428638 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=428638&action=review r=me with one nit. > Source/JavaScriptCore/ChangeLog:10 > + pointer from CallLinkInfo, and indrect calling that pointer. This means that nit -> indirect Created attachment 428860 [details]
patch for landing
Getting help from Caio on Slack. He isn't able to reproduce the failure locally. Will land for now, and we'll fix testapi on armv7 if failures are caused. Committed r277680 (237881@main): <https://commits.webkit.org/237881@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428860 [details]. |