Bug 225319

Summary: Dynamically pass capture sandbox extensions to GPUProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 228827    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2021-05-03 11:37:07 PDT
Dynamically pass capture sandbox extensions to GPUProcess
Attachments
Patch (15.38 KB, patch)
2021-05-03 11:40 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (15.46 KB, patch)
2021-05-04 01:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (15.43 KB, patch)
2021-05-04 03:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (15.96 KB, patch)
2021-05-05 00:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (15.96 KB, patch)
2021-05-05 01:00 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-05-03 11:40:27 PDT
Created attachment 427581 [details] Patch
youenn fablet
Comment 2 2021-05-04 01:45:11 PDT
Created attachment 427645 [details] Patch
youenn fablet
Comment 3 2021-05-04 03:06:32 PDT
<rdar://76855590>
youenn fablet
Comment 4 2021-05-04 03:09:52 PDT
Created attachment 427647 [details] Patch
Eric Carlson
Comment 5 2021-05-04 08:35:29 PDT
Comment on attachment 427647 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427647&action=review > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:190 > + SandboxExtension::createHandleForMachLookup("com.apple.applecamerad"_s, WTF::nullopt, appleCameraServicePathSandboxExtensionHandle); > + extensions.append(WTFMove(appleCameraServicePathSandboxExtensionHandle)); > +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE) > + SandboxExtension::Handle additionalAppleCameraServicePathSandboxExtensionHandle; > + SandboxExtension::createHandleForMachLookup("com.apple.appleh13camerad"_s, WTF::nullopt, additionalAppleCameraServicePathSandboxExtensionHandle); It would be good to release log and not set `m_hasSentCameraSandboxExtension` if we can't create either of these like we do for "com.apple.webkit.camera".
youenn fablet
Comment 6 2021-05-05 00:28:05 PDT
(In reply to Eric Carlson from comment #5) > Comment on attachment 427647 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427647&action=review > > > Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:190 > > + SandboxExtension::createHandleForMachLookup("com.apple.applecamerad"_s, WTF::nullopt, appleCameraServicePathSandboxExtensionHandle); > > + extensions.append(WTFMove(appleCameraServicePathSandboxExtensionHandle)); > > +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE) > > + SandboxExtension::Handle additionalAppleCameraServicePathSandboxExtensionHandle; > > + SandboxExtension::createHandleForMachLookup("com.apple.appleh13camerad"_s, WTF::nullopt, additionalAppleCameraServicePathSandboxExtensionHandle); > > It would be good to release log and not set > `m_hasSentCameraSandboxExtension` if we can't create either of these like we > do for "com.apple.webkit.camera". OK, will do
youenn fablet
Comment 7 2021-05-05 00:30:15 PDT
Created attachment 427735 [details] Patch
youenn fablet
Comment 8 2021-05-05 01:00:04 PDT
Created attachment 427737 [details] Patch
EWS
Comment 9 2021-05-05 01:53:39 PDT
Committed r277010 (237326@main): <https://commits.webkit.org/237326@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427737 [details].
Note You need to log in before you can comment on or make changes to this bug.