Bug 225254

Summary: [Cocoa] Calling into -[AVPlayerItem currentTime] is very expensive
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225371
https://bugs.webkit.org/show_bug.cgi?id=227136
Bug Depends on:    
Bug Blocks: 225262    
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Description Jer Noble 2021-04-30 15:22:04 PDT 
[Cocoa] Calling into -[AVPlayerItem currentTime] is very expensive
Comment 1 Jer Noble 2021-04-30 15:27:18 PDT 
Created attachment 427458 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-30 15:28:08 PDT 
<rdar://problem/77401450>
Comment 3 Eric Carlson 2021-04-30 15:36:55 PDT 
Comment on attachment 427458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427458&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1109
> +    auto currentTimeInterval = CMTimeMake(1, 10);

Do we need this local variable?
Comment 4 Jer Noble 2021-04-30 17:06:32 PDT 
Created attachment 427470 [details]
Patch for landing
Comment 5 EWS 2021-04-30 19:11:59 PDT 
Committed r276870 (237216@main): <https://commits.webkit.org/237216@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427470 [details].