Bug 225237

Summary: Make destination color space enumeration match supported destination color spaces for the port
Product: WebKit Reporter: Sam Weinig <sam>
Component: PlatformAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, darin, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, sam, schenney, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 225140    
Attachments:
Description Flags
WIP
none
Patch none

Description Sam Weinig 2021-04-30 10:33:05 PDT 
Currently, the destination color space enumeration doesn't match the supported destination color spaces for the port it is compiling on at least in the one case of CoreGraphics + Windows which does not support linear-srgb. We should be constrain the types to the supported set to make it clear what is happening at all call sites and prepare for world with more predefined destination color spaces that is coming soon.
Comment 1 Sam Weinig 2021-04-30 10:39:20 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-04-30 18:23:37 PDT 
Created attachment 427478 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-05-01 10:29:16 PDT 
Comment on attachment 427478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427478&action=review

> Source/WebCore/ChangeLog:13
> +        the Apple Windows port. Now, the callers are responisble for dealing with a

responisble
Comment 4 EWS 2021-05-01 11:06:16 PDT 
Committed r276875 (237221@main): <https://commits.webkit.org/237221@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427478 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-01 11:07:15 PDT 
<rdar://problem/77419870>