| Summary: | Update WPT tests in html/canvas/element/wide-gamut-canvas | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, clopez, darin, ews-watchlist, simon.fraser, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 225140 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2021-04-28 17:35:27 PDT
Created attachment 427315 [details]
Patch
Created attachment 427316 [details]
Patch
Comment on attachment 427316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427316&action=review > LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3-expected.txt:5 > +FAIL test getImageData with display-p3 and uint8 from display p3 uint8 canvas assert_approx_equals: expected 62 +/- 2 but got 50 Do you know why this fails? (In reply to Darin Adler from comment #3) > Comment on attachment 427316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427316&action=review > > > LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3-expected.txt:5 > > +FAIL test getImageData with display-p3 and uint8 from display p3 uint8 canvas assert_approx_equals: expected 62 +/- 2 but got 50 > > Do you know why this fails? Yeah, we don't support P3 canvas at all yet. Any passes in this directory are just the test not fully testing what it thinks it is testing. Working toward adding P3 canvas in https://bugs.webkit.org/show_bug.cgi?id=225140. And thank you for the review! Committed r276776 (237160@main): <https://commits.webkit.org/237160@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427316 [details]. |