Bug 225177

Summary: Update WPT tests in html/canvas/element/wide-gamut-canvas
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, darin, ews-watchlist, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 225140    
Attachments:
Description Flags
Patch
none
Patch none

Sam Weinig
Reported 2021-04-28 17:35:27 PDT
Update WPT tests in html/canvas/element/wide-gamut-canvas
Attachments
Patch (143.48 KB, patch)
2021-04-28 17:37 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (147.80 KB, patch)
2021-04-28 17:42 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-04-28 17:37:45 PDT
Created attachment 427315 [details] Patch
Sam Weinig
Comment 2 2021-04-28 17:42:32 PDT
Created attachment 427316 [details] Patch
Darin Adler
Comment 3 2021-04-29 08:19:58 PDT
Comment on attachment 427316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427316&action=review > LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3-expected.txt:5 > +FAIL test getImageData with display-p3 and uint8 from display p3 uint8 canvas assert_approx_equals: expected 62 +/- 2 but got 50 Do you know why this fails?
Sam Weinig
Comment 4 2021-04-29 08:28:15 PDT
(In reply to Darin Adler from comment #3) > Comment on attachment 427316 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427316&action=review > > > LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.to.p3-expected.txt:5 > > +FAIL test getImageData with display-p3 and uint8 from display p3 uint8 canvas assert_approx_equals: expected 62 +/- 2 but got 50 > > Do you know why this fails? Yeah, we don't support P3 canvas at all yet. Any passes in this directory are just the test not fully testing what it thinks it is testing. Working toward adding P3 canvas in https://bugs.webkit.org/show_bug.cgi?id=225140.
Sam Weinig
Comment 5 2021-04-29 08:28:32 PDT
And thank you for the review!
EWS
Comment 6 2021-04-29 09:04:26 PDT
Committed r276776 (237160@main): <https://commits.webkit.org/237160@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427316 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-29 09:05:19 PDT
<rdar://problem/77323985>
Note You need to log in before you can comment on or make changes to this bug.