Bug 225160

Summary: REGRESSION(r276689): [ iOS wk2 ] platform/ios/ios/storage/domstorage/5mb-quota.html is a constant text failure
Product: WebKit Reporter: Robert Jenner <jenner>
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, cdumez, commit-queue, jbedard, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225123
Bug Depends on: 225188    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Robert Jenner
Reported 2021-04-28 12:34:24 PDT
platform/ios/ios/storage/domstorage/5mb-quota.html is a constant text failure on iOS-Simulator wk2. HISTORY: https://results.webkit.org/?suite=layout-tests&test=platform%2Fios%2Fios%2Fstorage%2Fdomstorage%2F5mb-quota.html History looks like it has a pretty clear regress point. Will verify shortly. DIFF LINK: https://build.webkit.org/results/Apple-iOS-14-Simulator-Debug-WK2-Tests/r276689%20(1032)/platform/ios/ios/storage/domstorage/5mb-quota-diff.txt DIFF TEXT: PASS data.length is 65536 Putting 'data' into 39 localStorage buckets. Putting 'data' into another bucket.h -PASS Hit exception as expected +FAIL Did not hit quota error. Verify that data was never inserted. -PASS storage.getItem(39) is null +FAIL storage.getItem(39) should be null (of type object). Was XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX (of type string). Removing bucket 38. Adding 'Hello!' into a new bucket. PASS Insertion worked.
Attachments
Patch (1.68 KB, patch)
2021-04-28 14:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-04-28 12:38:40 PDT
<rdar://problem/77279334>
Robert Jenner
Comment 2 2021-04-28 14:41:35 PDT
I was able to reproduce the failure at iOS14 Simulator Release ToT using the following test: run-webkit-tests --ios-simulator platform/ios/ios/storage/domstorage/5mb-quota.html -f Was able to reproduce the failure at r276689, but not at r276688. It appears changes introduced here caused the failure: https://trac.webkit.org/changeset/276689/webkit
Chris Dumez
Comment 3 2021-04-28 14:54:48 PDT
Created attachment 427297 [details] Patch
EWS
Comment 4 2021-04-28 15:46:36 PDT
Committed r276736 (237137@main): <https://commits.webkit.org/237137@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427297 [details].
Aakash Jain
Comment 5 2021-04-29 05:45:28 PDT
platform/ios/ios/storage/domstorage/5mb-quota.html is still failing. History: https://results.webkit.org/?suite=layout-tests&test=platform%2Fios%2Fios%2Fstorage%2Fdomstorage%2F5mb-quota.html
WebKit Commit Bot
Comment 6 2021-04-29 05:50:45 PDT
Re-opened since this is blocked by bug 225188
Chris Dumez
Comment 7 2021-04-29 08:06:29 PDT
<https://commits.webkit.org/237158@main>
Note You need to log in before you can comment on or make changes to this bug.