Bug 225150

Summary: webkitpy tests fail when HEAD is a merge commit or git author email is not an email
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-04-28 06:50:31 PDT
The merge case is more annoying than the latter, but my initial start at trying to fix this in webkitscmpy ran into its extensive mocking of git and I didn't have the energy to figure it out. Throwing the patch up here so it's at least somewhere that isn't my local drive. (Sidenote: would be good for the mock to throw or otherwise error if it gets arguments it isn't expecting.)
Attachments
Patch (16.20 KB, patch)
2021-04-28 06:59 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Patch (7.95 KB, patch)
2021-04-28 07:00 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-04-28 06:59:16 PDT
Created attachment 427258 [details] Patch
Sam Sneddon [:gsnedders]
Comment 2 2021-04-28 07:00:13 PDT
Created attachment 427260 [details] Patch
Jonathan Bedard
Comment 3 2021-04-28 15:58:41 PDT
This is a fun one that I've encountered too, and we should fix it. I originally implemented this with deliberately strict regexes, and breaking not supporting merge-commits was also a deliberate choice, but maybe not the correct choice given the way folks do local development.
Radar WebKit Bug Importer
Comment 4 2021-05-05 06:51:16 PDT
<rdar://problem/77555267>
Note You need to log in before you can comment on or make changes to this bug.