Bug 225150

Summary: webkitpy tests fail when HEAD is a merge commit or git author email is not an email
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: jbedard, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Sam Sneddon [:gsnedders] 2021-04-28 06:50:31 PDT 
The merge case is more annoying than the latter, but my initial start at trying to fix this in webkitscmpy ran into its extensive mocking of git and I didn't have the energy to figure it out. Throwing the patch up here so it's at least somewhere that isn't my local drive.

(Sidenote: would be good for the mock to throw or otherwise error if it gets arguments it isn't expecting.)
Comment 1 Sam Sneddon [:gsnedders] 2021-04-28 06:59:16 PDT 
Created attachment 427258 [details]
Patch
Comment 2 Sam Sneddon [:gsnedders] 2021-04-28 07:00:13 PDT 
Created attachment 427260 [details]
Patch
Comment 3 Jonathan Bedard 2021-04-28 15:58:41 PDT 
This is a fun one that I've encountered too, and we should fix it. I originally implemented this with deliberately strict regexes, and breaking not supporting merge-commits was also a deliberate choice, but maybe not the correct choice given the way folks do local development.
Comment 4 Radar WebKit Bug Importer 2021-05-05 06:51:16 PDT 
<rdar://problem/77555267>