Bug 22515 – build-webkit --chromium should build Chromium's WebKit port

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

build-webkit --chromium should build Chromium's WebKit port

In order to be good webkit citizens, we should fully integrate with the rest of the WebKit build system.  So build-webkit should "just work" for chromium, along with all the other tools.  This will take a few rounds of patches.  This bug will cover getting "build-webkit --chromium" up and working on at least mac.

[Eric Seidel (no email)]

Created attachment 25531 [details]
Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium

 WebKitTools/ChangeLog                        |   16 ++++++
 WebKitTools/Scripts/build-dumprendertree     |    2 +-
 WebKitTools/Scripts/build-jsc                |    2 +-
 WebKitTools/Scripts/build-webkit             |   29 +++++------
 WebKitTools/Scripts/gdb-safari               |    2 +-
 WebKitTools/Scripts/run-javascriptcore-tests |    4 +-
 WebKitTools/Scripts/run-webkit-tests         |   14 +++---
 WebKitTools/Scripts/webkitdirs.pm            |   72 +++++++++++++++++---------
 8 files changed, 89 insertions(+), 52 deletions(-)

[Eric Seidel (no email)]

Created attachment 25532 [details]
Change a few calls to isCygwin to isAppleWinWebKit and isAppleMacWebKit to isDarwin in preperation for a --chromium build

 WebCore/WebCore.xcodeproj/project.pbxproj |    3 +-
 WebKitTools/ChangeLog                     |   12 +++++++++++
 WebKitTools/Scripts/build-webkit          |   10 ++++----
 WebKitTools/Scripts/webkitdirs.pm         |   30 ++++++++++++++--------------
 4 files changed, 34 insertions(+), 21 deletions(-)

[Eric Seidel (no email)]

Created attachment 25533 [details]
Add support for build-webkit --chromium

 WebKitTools/ChangeLog             |   11 +++++++
 WebKitTools/Scripts/build-webkit  |    8 ++++-
 WebKitTools/Scripts/webkitdirs.pm |   60 +++++++++++++++++-------------------
 3 files changed, 46 insertions(+), 33 deletions(-)

[Eric Seidel (no email)]

Created attachment 25536 [details]
More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.

 WebKitTools/ChangeLog                    |   15 +++++++++++++++
 WebKitTools/Scripts/build-dumprendertree |    2 +-
 WebKitTools/Scripts/build-jsc            |    2 +-
 WebKitTools/Scripts/build-webkit         |    4 ++--
 WebKitTools/Scripts/run-webkit-tests     |    4 ++--
 WebKitTools/Scripts/webkitdirs.pm        |    4 ++--
 6 files changed, 23 insertions(+), 8 deletions(-)

[Nikolas Zimmermann]

Comment on attachment 25531 [details]
Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium

Looks sane. r=me.

[Nikolas Zimmermann]

Comment on attachment 25532 [details]
Change a few calls to isCygwin to isAppleWinWebKit and isAppleMacWebKit to isDarwin in preperation for a --chromium build

I'm not sure the project.pbxproj changes are relevant? Please remove, then r=me.

[Nikolas Zimmermann]

Comment on attachment 25536 [details]
More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.

All patches looks sane.

[Mark Rowe (bdash)]

There doesn't seem to be any logic as to which changes are in each patch.  One of the earlier patches changes a bunch of isOSX to isAppleMacWebKit, which a later patch then changes to isDarwin.  It would be much clearer to change things directly from isOSX to isDarwin if they were incorrect.  Overall these just feel like four commits to save your place along the way as you were working rather than logical, discrete patches to land in SVN.

[Eric Seidel (no email)]

Landed.