| Summary: | [clang] Remove implicit cast related warnings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||
| Component: | Platform | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | Basuke.Suzuki, darin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224797 | ||||||
| Attachments: |
|
||||||
|
Description
Basuke Suzuki
2021-04-27 22:25:48 PDT
Created attachment 427239 [details]
PATCH
Comment on attachment 427239 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:490 > + ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit))); The cast here is OK, but this code is really strange. Comment on attachment 427239 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review >> Source/WebCore/layout/inlineformatting/InlineLine.cpp:490 >> + ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit))); > > The cast here is OK, but this code is really strange. I would like someone to explain this assertion at some point. Committed r276726 (237127@main): <https://commits.webkit.org/237127@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427239 [details]. |