Bug 225139

Summary: [clang] Remove implicit cast related warnings
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224797
Attachments:
Description Flags
PATCH none

Basuke Suzuki
Reported 2021-04-27 22:25:48 PDT
Only happens when building debug.
Attachments
PATCH (1.48 KB, patch)
2021-04-27 22:27 PDT, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2021-04-27 22:27:35 PDT
Created attachment 427239 [details] PATCH
Darin Adler
Comment 2 2021-04-28 11:25:44 PDT
Comment on attachment 427239 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:490 > + ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit))); The cast here is OK, but this code is really strange.
Darin Adler
Comment 3 2021-04-28 11:27:01 PDT
Comment on attachment 427239 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review >> Source/WebCore/layout/inlineformatting/InlineLine.cpp:490 >> + ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit))); > > The cast here is OK, but this code is really strange. I would like someone to explain this assertion at some point.
EWS
Comment 4 2021-04-28 11:53:20 PDT
Committed r276726 (237127@main): <https://commits.webkit.org/237127@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427239 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-28 11:54:19 PDT
<rdar://problem/77277039>
Note You need to log in before you can comment on or make changes to this bug.