Bug 225117

Summary: IPC::decoder::decode() should mark decoder as invalid when failing
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, darin, ggaren, kkinnunen, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225110
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-04-27 12:52:23 PDT
IPC::decoder::decode() should mark decoder as invalid when failing, instead of relying on individual type decoders to do so.
Attachments
Patch (18.42 KB, patch)
2021-04-27 12:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (31.22 KB, patch)
2021-04-27 13:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (32.61 KB, patch)
2021-04-27 13:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-27 12:54:49 PDT
Created attachment 427183 [details] Patch
Chris Dumez
Comment 2 2021-04-27 13:22:09 PDT
Created attachment 427186 [details] Patch
Chris Dumez
Comment 3 2021-04-27 13:35:19 PDT
Created attachment 427189 [details] Patch
Darin Adler
Comment 4 2021-04-27 16:09:12 PDT
Comment on attachment 427189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427189&action=review > Source/WebKit/ChangeLog:10 > + IPC::decoder::decode() should mark decoder as invalid when failing, instead of relying > + on individual type decoders to do so. This makes type decoders a bit simpler and less > + error-prone. Seems like the risk here is if any caller was calling an individual type decoder directly. If it was, then the markInvalid no longer happens. Benefit is very high, I definitely approve of this idea.
EWS
Comment 5 2021-04-27 16:35:31 PDT
Committed r276678 (237095@main): <https://commits.webkit.org/237095@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427189 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-27 16:36:23 PDT
<rdar://problem/77237455>
Note You need to log in before you can comment on or make changes to this bug.