Summary: | [css-flexbox] Fix expectations of a WPT test that works fine | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | clopez, darin, ews-watchlist, pnormand, rbuis, rego, svillar, webkit-bug-importer, youennf, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Sergio Villar Senin
2021-04-27 04:15:00 PDT
Created attachment 427135 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 427135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427135&action=review r=me, please wait for having green EWSs before landing. > LayoutTests/imported/w3c/ChangeLog:9 > + Fixed the paths of some images that were not properly converted during import. Is there a bug reported for the import script so this doesn't happen in the future? It looks like next time we use the script to re-import things, this change might be overwritten. Can we change the test in a way that we workaround the import script? Maybe using full paths from "/" or something like that. And export that change into WPT. Mostly to avoid having the same issue next time we re-sync the tests. (In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 427135 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427135&action=review > > r=me, please wait for having green EWSs before landing. > > > LayoutTests/imported/w3c/ChangeLog:9 > > + Fixed the paths of some images that were not properly converted during import. > > Is there a bug reported for the import script so this doesn't happen in the > future? > > It looks like next time we use the script to re-import things, this change > might be overwritten. > Can we change the test in a way that we workaround the import script? Maybe > using full paths from "/" or something like that. And export that change > into WPT. > Mostly to avoid having the same issue next time we re-sync the tests. Good point. There is however a ../support but also a support/. So the test might have been moved upstream in between directories. I'll keep an eye in the next import and report any issue related to that I might encounter. Committed r276690 (237104@main): <https://commits.webkit.org/237104@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427135 [details]. |