| Summary: | ANGLE X11 build fixes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | ANGLE | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, ews-watchlist, graouts, jdarpinian, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2021-04-23 15:41:43 PDT
Created attachment 426957 [details]
Patch
Comment on attachment 426957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426957&action=review Seems fine. r+ > Source/WebCore/platform/graphics/angle/ANGLEHeaders.h:52 > +#if defined(None) Would it be possible to put some guard around this entire block so it only applies to X11 platforms? If not, that's OK. (In reply to Kenneth Russell from comment #2) > Comment on attachment 426957 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426957&action=review > > Seems fine. r+ > > > Source/WebCore/platform/graphics/angle/ANGLEHeaders.h:52 > > +#if defined(None) > > Would it be possible to put some guard around this entire block so it only > applies to X11 platforms? If not, that's OK. It seemed to be dragging in X11 headers on Linux even when `angle_use_x11` and `ENABLE_X11_TARGET` were OFF. Comment on attachment 426957 [details]
Patch
Talked to mcatanzaro and there doesn't seem to be a good way to guard the set of checks. The other file using it also does the same unconditionally.
Committed r276591 (237027@main): <https://commits.webkit.org/237027@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426957 [details]. |