jsonchecker.py validate_string uses Python 2 basestring type instead of Python 2/3 str type

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tyler Wilcock]

This causes the check to exit early the first time it validates a string.  This error is then printed:

name 'basestring' is not defined

We can use the str type instead, which is valid for both Python 2 and Python 3.

[Tyler Wilcock]

Created attachment 426909 [details]
Patch

[Jonathan Bedard]

Comment on attachment 426909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426909&action=review

> Source/WebCore/css/CSSProperties.json:7233
> +        },

This change seems like it should be separate and doesn't match what the bug description says.

[Tyler Wilcock]

Created attachment 426933 [details]
Patch

[Tyler Wilcock]

(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 426909 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426909&action=review
> 
> > Source/WebCore/css/CSSProperties.json:7233
> > +        },
> 
> This change seems like it should be separate and doesn't match what the bug
> description says.
OK, I uploaded a new patch with just the jsonchecker.py changes.

[EWS]

Committed r276564 (237000@main): <https://commits.webkit.org/237000@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426933 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77124938>