Bug 224978

Summary: jsonchecker.py validate_string uses Python 2 basestring type instead of Python 2/3 str type
Product: WebKit Reporter: Tyler Wilcock <twilco.o>
Component: Tools / TestsAssignee: Tyler Wilcock <twilco.o>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, joepeck, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2021-04-23 07:57:52 PDT
This causes the check to exit early the first time it validates a string. This error is then printed: name 'basestring' is not defined We can use the str type instead, which is valid for both Python 2 and Python 3.
Attachments
Patch (3.80 KB, patch)
2021-04-23 08:17 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2021-04-23 12:27 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tyler Wilcock
Comment 1 2021-04-23 08:17:01 PDT
Created attachment 426909 [details] Patch
Jonathan Bedard
Comment 2 2021-04-23 11:08:53 PDT
Comment on attachment 426909 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426909&action=review > Source/WebCore/css/CSSProperties.json:7233 > + }, This change seems like it should be separate and doesn't match what the bug description says.
Tyler Wilcock
Comment 3 2021-04-23 12:27:17 PDT
Created attachment 426933 [details] Patch
Tyler Wilcock
Comment 4 2021-04-23 12:28:03 PDT
(In reply to Jonathan Bedard from comment #2) > Comment on attachment 426909 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426909&action=review > > > Source/WebCore/css/CSSProperties.json:7233 > > + }, > > This change seems like it should be separate and doesn't match what the bug > description says. OK, I uploaded a new patch with just the jsonchecker.py changes.
EWS
Comment 5 2021-04-25 10:40:06 PDT
Committed r276564 (237000@main): <https://commits.webkit.org/237000@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426933 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-25 10:41:15 PDT
<rdar://problem/77124938>
Note You need to log in before you can comment on or make changes to this bug.