| Summary: | Modernize ShareableResource::Handle | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | cdumez, cgarcia, ews-watchlist, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2021-04-22 17:11:58 PDT
Created attachment 426869 [details]
Patch
iOS bots are red. Created attachment 427165 [details]
Patch
Comment on attachment 427165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427165&action=review > Source/WebKit/Shared/ShareableResource.cpp:148 > +auto ShareableResource::createHandle() -> Optional<Handle> It seems weird to use Optional<Handle> considering that Handle has a "null" state and a isNull() function. For example, we purposely avoid using Optional<String> in the code base, for this exact reason. I think we could simply return a null Handle in case of failure. |