Bug 224937

Summary: Call RemoteMediaEngineConfigurationFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, peng.liu6, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Chris Dumez 2021-04-22 09:33:43 PDT 
Call RemoteMediaEngineConfigurationFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia(), like we used to done, instead of doing it in the GPUProcessConnection constructor. It is safer to register the factory before we have a GPUProcessConnection and we wouldn't want things to behave differently depending on whether or not the GPUProcess is already launched. I made sure that this does not eagerly launch the GPUProcess.
Comment 1 Chris Dumez 2021-04-22 09:37:40 PDT 
Created attachment 426824 [details]
Patch
Comment 2 Eric Carlson 2021-04-22 13:50:48 PDT 
Comment on attachment 426824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426824&action=review

> Source/WebKit/ChangeLog:9
> +        like we used to done, instead of doing it in the GPUProcessConnection constructor. It is safer to

s/used to done/used to do/
Comment 3 Chris Dumez 2021-04-22 13:53:00 PDT 
Committed r276460 (236920@main): <https://commits.webkit.org/236920@main>
Comment 4 Radar WebKit Bug Importer 2021-04-22 15:48:54 PDT 
<rdar://problem/77042248>