Bug 224921

Summary: [GTK] Turn on editable <input type=date> and <input type=time> fields
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, berto, bugs-noreply, cdumez, cgarcia, ews-watchlist, gustavo, gyuyoung.kim, japhet, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 98936    
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2021-04-22 02:01:19 PDT
We can turn on this feature without actually implementing support for the date picker. This will enable the interior shadow DOM of these input elements allowing for proper input via the keyboard of dates and times. The reasoning for not implementing the date picker UI is that the code currently assumes that the date picker UI can be used without taking focus from the browser window. This isn't as straight-forward to implement in GTK.
Attachments
Patch (30.03 KB, patch)
2021-04-22 06:26 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (23.18 KB, patch)
2021-04-22 06:27 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-04-22 06:26:26 PDT
Created attachment 426805 [details] Patch
Martin Robinson
Comment 2 2021-04-22 06:27:54 PDT
Created attachment 426806 [details] Patch
EWS Watchlist
Comment 3 2021-04-22 06:29:08 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS
Comment 4 2021-04-22 11:10:02 PDT
Committed r276448 (236908@main): <https://commits.webkit.org/236908@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426806 [details].
Note You need to log in before you can comment on or make changes to this bug.