Bug 224914

Summary:

[RenderTreeBuilder] Multi-column spanners are not part of the enclosing multi-column renderer's subtree

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-04-21 20:58:39 PDT

<rdar://76846946>

Comment 1 zalan 2021-04-21 21:15:05 PDT

Created attachment 426769 [details]
Patch

Comment 2 Simon Fraser (smfr) 2021-04-21 21:29:12 PDT

Comment on attachment 426769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426769&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:749
> +                    // This child is a spanner so it is not in the subtree of the multicolumn renderer (parented directly under the block flow). 

The parenthetical adds confusion. Write it as a new sentence.

Comment 3 zalan 2021-04-22 10:25:04 PDT

Created attachment 426826 [details]
Patch

Comment 4 EWS 2021-04-22 15:02:23 PDT

Committed r276464 (236924@main): <https://commits.webkit.org/236924@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426826 [details].