Bug 22491 – Add unit test skeleton for the WebKit/Gtk+ API

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Holger Freyther]

Use the glib testing classes to test our API.

[Holger Freyther]

Created attachment 25493 [details]
Add unit test skeletong for WebKit/Gtk+

Integrate unit testing into the build process. glib 2.16 introduced the testing classes and the code should cope with that.

[Eric Seidel (no email)]

Comment on attachment 25493 [details]
Add unit test skeletong for WebKit/Gtk+

It seems silly to add this w/o any test at all.  How do we know it works if it doesn't actually test anything?  Also the pre 2.1.6 version shoudn't just return 0, it should probably at least write a message to the console, no?  and probably return 1?  Whatever tool is calling it should know the tests failed to run because it was built with an old gtk, no?

[Holger Freyther]

Hmm. there is a test inside the Bug #21837 and it is blocked by the skeleton and build change to be added. It makes sense to do the split up. So I don't think it is silly at all.

As the skeleton/framework/buildsystem has nothing to do with the issue of #21837 I have done the split up...

And regarding pre glib 2.16 versions. I think people using it are stuck in the past and will not be able to run "run-webkit-tests" anyway. I don't mind adding a message that unit testing is not possible but I doubt anyone with older glib will see it.

So as there is a test in the queue as well would you please reconsider your "silly" statement?

[Holger Freyther]

Created attachment 25519 [details]
Add unit test skeleton for WebKit/Gtk+

This is about the questions:
  - Do we test the API?
  - How do we test (which framework to use)?
  - Where do we put the test(s)?

My answers:
  - Sure
  - We use the glib testing facilities
  - Like Gtk/Glib in a "tests" directory next to the source


What we test:
   - There is a first bug with test case in the referenced bug, so this bug actually has an impact. But in general that is a different question and depends on the actual bug and feature...

[Eric Seidel (no email)]

Comment on attachment 25519 [details]
Add unit test skeleton for WebKit/Gtk+

Looks fine.

You'll need a ChangeLog when you land of course.  Also, generally the copyright line includes the author's email, but I guess that's not required.

[Holger Freyther]

Created attachment 25527 [details]
Reference of skeleton + test case

This is for reference to see how the skeleton is filled with content. I would prefer if the test case is landed together with the bugfix from bug #21837.

The skeleton should just be added before the landing of the fix...

[Holger Freyther]

Landed in r39082. The skeleton will be filled with content once we have a fix for Bug #21837.