| Summary: | Sometimes appHighlights are not painted when created. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | koivisto, thorton, webkit-bug-importer, zalan | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Megan Gardner
2021-04-21 16:27:05 PDT
Created attachment 426752 [details]
Patch
Comment on attachment 426752 [details]
Patch
Please add a test.
Created attachment 426789 [details]
Patch
Created attachment 426791 [details]
Patch
Created attachment 426829 [details]
Patch
Comment on attachment 426829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426829&action=review You can just forward Antti's review. > Source/WebCore/ChangeLog:7 > + Somehow you lost the `New test: ...` line here > Source/WebCore/ChangeLog:8 > + In order for highlights to be painted correclty, we need to not use the new line layout code, "correctly" Created attachment 426838 [details]
Patch
Created attachment 426885 [details]
Patch for landing
Committed r276484 (236943@main): <https://commits.webkit.org/236943@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426885 [details]. |