Crash under RegistrationDatabase::openSQLiteDatabase()

• Component: Service Workers
• Status: RESOLVED FIXED

[Chris Dumez]

Crash under RegistrationDatabase::openSQLiteDatabase():
Thread 17 name:  Dispatch queue: ServiceWorker I/O Thread
Thread 17 Crashed ↩:
0   JavaScriptCore                	0x00000001aaada524 WTF::StringImpl::stripWhiteSpace() + 92 (StringImpl.cpp:736)
1   JavaScriptCore                	0x00000001aab2fdf4 WTF::String::stripWhiteSpace() const + 40 (WTFString.cpp:377)
2   JavaScriptCore                	0x00000001aab2fdf4 WTF::String::stripWhiteSpace() const + 40 (WTFString.cpp:377)
3   WebCore                       	0x00000001aedb8830 WebCore::SQLiteStatement::prepare() + 64 (SQLiteStatement.cpp:62)
4   WebCore                       	0x00000001aedb8a70 WebCore::SQLiteStatement::executeCommand() + 116 (SQLiteStatement.cpp:132)
5   WebCore                       	0x00000001af37cbd8 WebCore::RegistrationDatabase::openSQLiteDatabase(WTF::String const&) + 1292 (SQLiteDatabase.cpp:376)
6   WebCore                       	0x00000001af3946c4 WTF::Detail::CallableWrapper<WebCore::RegistrationDatabase::schedulePushChanges(WTF::Vector<WebCore::ServiceWorkerContextData, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&, WTF::Vector<WebCore::ServiceWorkerRegistrationKey, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&, WTF::CompletionHandler<void ()>&&)::$_26, void>::call() + 120 (RegistrationDatabase.cpp:346)
7   libdispatch.dylib             	0x00000001a03cea54 _dispatch_call_block_and_release + 32 (init.c:1466)
8   libdispatch.dylib             	0x00000001a03d07ec _dispatch_client_callout + 20 (object.m:559)
9   libdispatch.dylib             	0x00000001a03d7fd4 _dispatch_lane_serial_drain + 620 (inline_internal.h:2557)
10  libdispatch.dylib             	0x00000001a03d8bd0 _dispatch_lane_invoke + 404 (queue.c:3862)
11  libdispatch.dylib             	0x00000001a03e348c _dispatch_workloop_worker_thread + 764 (queue.c:6589)
12  libsystem_pthread.dylib       	0x00000001eb54a7a4 _pthread_wqthread + 276 (pthread.c:2231)
13  libsystem_pthread.dylib       	0x00000001eb55174c start_wqthread + 8

[Chris Dumez]

<rdar://64574013>

[Chris Dumez]

Created attachment 426746 [details]
Patch

[Geoffrey Garen]

Comment on attachment 426746 [details]
Patch

r=me

[EWS]

Committed r276409 (236874@main): <https://commits.webkit.org/236874@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426746 [details].