| Summary: | [GPUP] Refactor SourceBuffer::enqueuedSamplesForTrackID() for testing purposes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||
| Component: | New Bugs | Assignee: | Peng Liu <peng.liu6> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 224139 | ||||||||
| Attachments: |
|
||||||||
|
Description
Peng Liu
2021-04-21 13:21:01 PDT
Created attachment 426739 [details]
Patch
Comment on attachment 426739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review > LayoutTests/media/media-source/media-source-append-presentation-durations.html:56 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Nit: `const enqueuedSamples = ...` > LayoutTests/media/media-source/media-source-erase-after-last-append.html:50 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Ditto > LayoutTests/media/media-source/media-source-first-append-not-starting-at-zero.html:45 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Nit: `let enqueuedSamples = ...` > LayoutTests/media/media-source/media-source-remove-b-frame.html:45 > + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); Ditto Created attachment 426744 [details]
[fast-cq] Patch for landing
Comment on attachment 426739 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426739&action=review >> LayoutTests/media/media-source/media-source-append-presentation-durations.html:56 >> + enqueuedSamples = await internals.enqueuedSamplesForTrackID(sourceBuffer, 1); > > Nit: `const enqueuedSamples = ...` Fixed this and all others. Thanks! Committed r276414 (236879@main): <https://commits.webkit.org/236879@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426744 [details]. |