Bug 224885

Summary: PCM: Remove PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable overrides in testing
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224321
https://bugs.webkit.org/show_bug.cgi?id=225364
Attachments:
Description Flags
Patch none

Description John Wilander 2021-04-21 12:21:02 PDT 
We had a temporary override to PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable in WebKit::PrivateClickMeasurementManager::getTokenPublicKey() and WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken(). We should remove those overrides since the network load hang has been resolved.
Comment 1 Radar WebKit Bug Importer 2021-04-21 12:22:50 PDT 
<rdar://problem/76973184>
Comment 2 John Wilander 2021-04-21 12:30:13 PDT 
Created attachment 426730 [details]
Patch
Comment 3 Brent Fulgham 2021-04-21 13:46:58 PDT 
Comment on attachment 426730 [details]
Patch

rs=me
Comment 4 John Wilander 2021-04-21 14:12:19 PDT 
Thanks, Brent! Waiting for EWS’s verdict before landing.
Comment 5 John Wilander 2021-04-21 17:35:41 PDT 
iOS bot test failure is unrelated.
Comment 6 EWS 2021-04-21 18:15:20 PDT 
Committed r276413 (236878@main): <https://commits.webkit.org/236878@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426730 [details].
Comment 7 Jiewen Tan 2021-05-04 13:06:33 PDT 
This change has caused TestWebKitAPI.EventAttribution.FraudPrevention to timeout.
Comment 8 Jiewen Tan 2021-05-04 13:41:20 PDT 
The change will be reverted in 224321 then.
Comment 9 Jiewen Tan 2021-05-04 13:45:18 PDT 
(In reply to Jiewen Tan from comment #7)
> This change has caused TestWebKitAPI.EventAttribution.FraudPrevention to
> timeout.

Here is the test history:
https://results.safari.apple.com/?suite=api-tests&test=TestWebKitAPI.EventAttribution.FraudPrevention.

And here is the range of changes:
https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=276427&stop_rev=276379&limit=999.

This is the only relevant change in that range. And I have locally confirmed that this is the cause.