Bug 224879

Summary: webkitpy's git code should always use --no-abbrev-commit
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-04-21 10:41:58 PDT
At least some of our tests break with log.abbrevCommit set to true. I don't know how much this breaks actual functionality, but we should simply outright avoid it being a risk by always passing --no-abbrev-commit to log/show which overrides the config option.
Attachments
Patch (6.43 KB, patch)
2021-04-21 10:49 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-04-21 10:49:29 PDT
Created attachment 426713 [details] Patch
EWS
Comment 2 2021-04-21 13:06:51 PDT
Committed r276387 (236862@main): <https://commits.webkit.org/236862@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426713 [details].
Radar WebKit Bug Importer
Comment 3 2021-04-22 18:08:12 PDT
<rdar://problem/77048736>
Note You need to log in before you can comment on or make changes to this bug.