Bug 224879

Summary:

webkitpy's git code should always use --no-abbrev-commit

Product:

WebKit

Reporter:

Sam Sneddon [:gsnedders] <gsnedders>

Component:

Tools / Tests

Assignee:

Sam Sneddon [:gsnedders] <gsnedders>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sam Sneddon [:gsnedders] 2021-04-21 10:41:58 PDT

At least some of our tests break with log.abbrevCommit set to true. I don't know how much this breaks actual functionality, but we should simply outright avoid it being a risk by always passing --no-abbrev-commit to log/show which overrides the config option.

Comment 1 Sam Sneddon [:gsnedders] 2021-04-21 10:49:29 PDT

Created attachment 426713 [details]
Patch

Comment 2 EWS 2021-04-21 13:06:51 PDT

Committed r276387 (236862@main): <https://commits.webkit.org/236862@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426713 [details].

Comment 3 Radar WebKit Bug Importer 2021-04-22 18:08:12 PDT

<rdar://problem/77048736>