DOMException should be Serializable

• Component: Bindings
• Status: RESOLVED FIXED

[Chris Lord]

According to the spec, DOMException is Serializable, but this isn't currently implemented: https://heycam.github.io/webidl/#dfn-DOMException

This is causing some WPT Worker tests to fail.

[Chris Lord]

Created attachment 426671 [details]
Patch

[Chris Lord]

Uploading the patch to determine if it's already tested (it is tested indirectly in css-font-loading WPT tests, but that relies on bug 224178 and I'd like to check this in before that) - if it isn't, I'll write a test.

[Chris Lord]

Created attachment 426673 [details]
Patch

[Chris Lord]

Created attachment 426676 [details]
Patch

[Chris Dumez]

Comment on attachment 426676 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426676&action=review

r=me with comments.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1389
> +                write(DOMExceptionTag);

I think it would be good to move this logic to a separate dumpDOMException() function, to follow the pattern used by other types.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:3595
> +            CachedStringRef name;

Ditto. It would be good to move this logic to a separate readDOMException() function.

> LayoutTests/storage/indexeddb/resources/structured-clone.js:-631
> -    evalAndExpectException("store.put(new DOMException, 'key')", "DOMException.DATA_CLONE_ERR");

Instead of simply drop it the check, can we switch it into a check that is supposed to succeed? It seems this test checks checks types that succeed and fail.

[Chris Lord]

Created attachment 426699 [details]
Patch

[Chris Lord]

Created attachment 426700 [details]
Patch

[EWS]

Committed r276372 (236849@main): <https://commits.webkit.org/236849@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426700 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77049131>