| Summary: | WebGL GPUP crashes when preparing for display due to off-thread WeakPtr access (IOSURFACE_SET_OWNERSHIP_IDENTITY) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
| Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, dino, kbr, kkinnunen, peng.liu6, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 224881 | ||||||
| Bug Blocks: | 217211 | ||||||
| Attachments: |
|
||||||
|
Description
Kimmo Kinnunen
2021-04-21 03:33:46 PDT
Created attachment 426666 [details]
Patch
Comment on attachment 426666 [details]
Patch
r=me
Committed r276363 (236841@main): <https://commits.webkit.org/236841@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426666 [details]. Comment on attachment 426666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426666&action=review > Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 > +#if HAVE(TASK_IDENTITY_TOKEN) Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? Comment on attachment 426666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426666&action=review >> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 >> +#if HAVE(TASK_IDENTITY_TOKEN) > > Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? Why? Comment on attachment 426666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426666&action=review >>> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 >>> +#if HAVE(TASK_IDENTITY_TOKEN) >> >> Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? > > Why? There will be a compiling error like "xxx is not used" if HAVE(TASK_IDENTITY_TOKEN) is true while HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY) is false. Will be fixed in https://bugs.webkit.org/show_bug.cgi?id=224881.(In reply to Peng Liu from comment #6) > Comment on attachment 426666 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426666&action=review > > >>> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 > >>> +#if HAVE(TASK_IDENTITY_TOKEN) > >> > >> Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? > > > > Why? > > There will be a compiling error like "xxx is not used" if > HAVE(TASK_IDENTITY_TOKEN) is true while > HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY) is false. FYI. It will be fixed in https://bugs.webkit.org/show_bug.cgi?id=224881. |