Summary: | Gigacage and DebugHeap compilation unit names clash with corresponding WTF names | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||
Component: | bmalloc | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | annulen, ap, ews-watchlist, ggaren, gyuyoung.kim, mmaxfield, ryuan.choi, sergio, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=224860 | ||||||
Attachments: |
|
Description
Kimmo Kinnunen
2021-04-21 02:27:58 PDT
Created attachment 426663 [details]
Patch
Comment on attachment 426663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426663&action=review > Source/bmalloc/ChangeLog:8 > + Rename DebugHeap.cpp, Gigacage.cpp with B prefix to avoid clashing with WTF compilation units. Is there no way to fix this without renaming? It seems impractical to change bmalloc whenever any client uses the same file name. I think one alternative is to encode the project name in the .o file, but I couldn't find Xcode options for that. E.g Compiling DebugHeap.cpp would produce libbmalloc-DebugHeap.o. As in: https://bugs.chromium.org/p/webrtc/issues/detail?id=6418 Comment on attachment 426663 [details]
Patch
r=me
*** This bug has been marked as a duplicate of bug 175997 *** |