Bug 224847

Summary: Long-pressing a data detectors link causes the link to be followed
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Tim Horton 2021-04-20 18:36:09 PDT 
Long-pressing a data detectors link causes the link to be followed
Comment 1 Tim Horton 2021-04-20 18:39:37 PDT 
Created attachment 426628 [details]
Patch
Comment 2 Tim Horton 2021-04-20 18:40:02 PDT 
<rdar://problem/72889738>
Comment 3 Tim Horton 2021-04-20 19:26:43 PDT 
Created attachment 426633 [details]
Patch
Comment 4 Wenson Hsieh 2021-04-20 19:32:58 PDT 
Comment on attachment 426633 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426633&action=review

r=mews

> Source/WebKit/Shared/NativeWebMouseEvent.h:73
> +    NativeWebMouseEvent(Type, Button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, float deltaX, float deltaY, float deltaZ, int clickCount, OptionSet<Modifier>, WallTime timestamp, double force, bool gestureCancelled);

Should `gestureCancelled` be an enum class type instead of a bool?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:251
> +    RetainPtr<WKTestingTouch> touch = adoptNS([[WKTestingTouch alloc] init]);

Nit - auto?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:255
> +    RetainPtr<WKTestingEvent> event = adoptNS([[WKTestingEvent alloc] init]);

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:268
> +    [webView _doAfterProcessingAllPendingMouseEvents:^{

Nit - this could be made slightly cleaner by using `[webView waitForPendingMouseEvents];`

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:291
> +    RetainPtr<WKTestingTouch> touch = adoptNS([[WKTestingTouch alloc] init]);

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:295
> +    RetainPtr<WKTestingEvent> event = adoptNS([[WKTestingEvent alloc] init]);

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:308
> +    [webView _doAfterProcessingAllPendingMouseEvents:^{

(Ditto)
Comment 5 Tim Horton 2021-04-20 23:50:01 PDT 
Created attachment 426652 [details]
Patch
Comment 6 EWS 2021-04-21 00:38:29 PDT 
Committed r276351 (236829@main): <https://commits.webkit.org/236829@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426652 [details].