Bug 224841 – v2: Web Inspector: exempt API::SharedJSContext from remote inspection and automatic inspection

• Component: Web Inspector
• Status: RESOLVED FIXED

[Blaze Burg]

The fix for bug 217109 was insufficient, I have a better fix.

[Blaze Burg]

<rdar://69386559>

[Blaze Burg]

Created attachment 426611 [details]
Patch v1.0

[Devin Rousso]

Comment on attachment 426611 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=426611&action=review

r=me

Out of curiosity, does this prevent inspection forever?  Or does it just prevent auto-attach/auto-pause?  Would be nice to still be able to inspect this later on if possible :)

> Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:52
>              [m_context _setRemoteInspectionEnabled:NO];

I think we can remove this since it's only set `if (JSRemoteInspectorGetInspectionEnabledByDefault())`.

[Blaze Burg]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 426611 [details]
> Patch v1.0
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426611&action=review
> 
> r=me
> 
> Out of curiosity, does this prevent inspection forever?  Or does it just
> prevent auto-attach/auto-pause?  Would be nice to still be able to inspect
> this later on if possible :)

The default is to not allow inspection, so yes, this would continue to not be listed. This could be fixed (i.e, for engineering purposes) by making JSRemoteInspectorGetInspectionEnabledByDefault always return true, or changing the default value of m_enabled in JSC::RemoteInspectionTarget. But in general, I don't think there is much point in exposing this context outside of engineering builds.

> 
> > Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:52
> >              [m_context _setRemoteInspectionEnabled:NO];
> 
> I think we can remove this since it's only set `if
> (JSRemoteInspectorGetInspectionEnabledByDefault())`.

True, it would default to false as explained above.

[Blaze Burg]

Committed r276446 (236906@main): <https://commits.webkit.org/236906@main>