Summary: | REGRESSION(r256107): Text moves around when selecting at https://www.tokyo-sports.co.jp/entame/news/2834187/ | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, darin, koivisto, simon.fraser, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=225074 | ||||||||
Attachments: |
|
Description
zalan
2021-04-20 15:53:58 PDT
Created attachment 426606 [details]
Patch
Comment on attachment 426606 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426606&action=review > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83 > auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox); "preseve" > Source/WebCore/layout/inlineformatting/text/TextUtil.h:57 > + static LineBreakIteratorMode lineBreakIteratorMode(LineBreak); Not the biggest fan of a class and file named TextUtil. (In reply to Darin Adler from comment #2) > Comment on attachment 426606 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426606&action=review > > > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83 > > auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox); > > "preseve" > > > Source/WebCore/layout/inlineformatting/text/TextUtil.h:57 > > + static LineBreakIteratorMode lineBreakIteratorMode(LineBreak); > > Not the biggest fan of a class and file named TextUtil. Me neither. It should have been renamed long time ago. Will take care of it. Created attachment 426629 [details]
Patch
Committed r276357 (236835@main): <https://commits.webkit.org/236835@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426629 [details]. |