Bug 224839

Summary: REGRESSION(r256107): Text moves around when selecting at https://www.tokyo-sports.co.jp/entame/news/2834187/
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, koivisto, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225074
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2021-04-20 15:53:58 PDT
<rdar://74958484>
Comment 1 zalan 2021-04-20 15:57:42 PDT
Created attachment 426606 [details]
Patch
Comment 2 Darin Adler 2021-04-20 18:28:04 PDT
Comment on attachment 426606 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426606&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83
>      auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox);

"preseve"

> Source/WebCore/layout/inlineformatting/text/TextUtil.h:57
> +    static LineBreakIteratorMode lineBreakIteratorMode(LineBreak);

Not the biggest fan of a class and file named TextUtil.
Comment 3 zalan 2021-04-20 18:39:39 PDT
(In reply to Darin Adler from comment #2)
> Comment on attachment 426606 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=426606&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:83
> >      auto shouldPreseveNewline = TextUtil::shouldPreserveNewline(inlineTextBox);
> 
> "preseve"
> 
> > Source/WebCore/layout/inlineformatting/text/TextUtil.h:57
> > +    static LineBreakIteratorMode lineBreakIteratorMode(LineBreak);
> 
> Not the biggest fan of a class and file named TextUtil.
Me neither. It should have been renamed long time ago. Will take care of it.
Comment 4 zalan 2021-04-20 18:57:51 PDT
Created attachment 426629 [details]
Patch
Comment 5 EWS 2021-04-21 06:36:41 PDT
Committed r276357 (236835@main): <https://commits.webkit.org/236835@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426629 [details].