Bug 224817

Summary: FullGCActivityCallback should use the percentage of pages uncompressed in RAM to determine deferral.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, fpizlo, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch for landing none

Keith Miller
Reported 2021-04-20 09:17:50 PDT
FullGCActivityCallback should use the percentage of pages uncompressed in RAM to determine deferral.
Attachments
Patch (10.40 KB, patch)
2021-04-20 09:53 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (10.72 KB, patch)
2021-04-20 10:18 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (13.32 KB, patch)
2021-04-20 10:57 PDT, Keith Miller 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.46 KB, patch)
2021-04-20 11:17 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (13.53 KB, patch)
2021-04-20 11:37 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (13.86 KB, patch)
2021-04-20 11:58 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.94 KB, patch)
2021-04-20 14:33 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2021-04-20 09:53:48 PDT
Created attachment 426561 [details] Patch
Keith Miller
Comment 2 2021-04-20 10:18:08 PDT
Created attachment 426563 [details] Patch
Keith Miller
Comment 3 2021-04-20 10:57:45 PDT
Created attachment 426569 [details] Patch
Keith Miller
Comment 4 2021-04-20 11:17:40 PDT
Created attachment 426571 [details] Patch
Darin Adler
Comment 5 2021-04-20 11:37:26 PDT
Comment on attachment 426571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426571&action=review > Source/WTF/ChangeLog:8 > + Add a noexecpt flavor of FunctionTraits. Why? Where is noexcept coming into play? Some std namespace function?
Keith Miller
Comment 6 2021-04-20 11:37:52 PDT
Created attachment 426575 [details] Patch
Keith Miller
Comment 7 2021-04-20 11:40:30 PDT
Comment on attachment 426571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426571&action=review >> Source/WTF/ChangeLog:8 >> + Add a noexecpt flavor of FunctionTraits. > > Why? Where is noexcept coming into play? Some std namespace function? mincore is marked noexcept on linux apparently, which is part of the reason I was getting build failures there.
Keith Miller
Comment 8 2021-04-20 11:58:40 PDT
Created attachment 426577 [details] Patch
Darin Adler
Comment 9 2021-04-20 13:08:56 PDT
Comment on attachment 426577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426577&action=review > Source/WTF/ChangeLog:8 > + Add a noexecpt flavor of FunctionTraits. I suggest you fix the typo here and mention mincore as the reason.
Keith Miller
Comment 10 2021-04-20 13:09:49 PDT
Comment on attachment 426577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426577&action=review >> Source/WTF/ChangeLog:8 >> + Add a noexecpt flavor of FunctionTraits. > > I suggest you fix the typo here and mention mincore as the reason. Sure, will do both before landing.
Keith Miller
Comment 11 2021-04-20 13:10:44 PDT
rdar://76425456
Keith Miller
Comment 12 2021-04-20 13:13:00 PDT
Comment on attachment 426577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426577&action=review In a follow up patch I'll make sure we account for PreciseAllocations too. > Source/JavaScriptCore/heap/BlockDirectory.cpp:80 > + // FIXME: We could cache this in bulk (e.g. 25 MB chunks) but we haven't seen any data that it actually matters. Actually, this probably shouldn't be marked as a FIXME since we're not actually going to fix this until we say data saying it matters.
Keith Miller
Comment 13 2021-04-20 14:33:16 PDT
Created attachment 426593 [details] Patch for landing
EWS
Comment 14 2021-04-20 15:42:13 PDT
Committed r276324 (236804@main): <https://commits.webkit.org/236804@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426593 [details].
Note You need to log in before you can comment on or make changes to this bug.