Summary: | Clean up handling of `-webkit-inline-flex`/`-webkit-flex` CSS display values | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||
Component: | CSS | Assignee: | Tim Nguyen (:ntim) <ntim> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 224574 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Tim Nguyen (:ntim)
2021-04-20 02:05:58 PDT
Sorry, the snippet I suggested was wrong, here's one that should be correct: + // Convert -webkit-flex/-webkit-inline-flex to flex/inline-flex + CSSValueID nextValueID = range.peek().id(); + if (nextValueID == CSSValueWebkitInlineFlex || nextValueID == CSSValueWebkitFlex) { + consumeIdent(range); + return CSSValuePool::singleton().createValue( + nextValueID == CSSValueWebkitInlineFlex ? CSSValueInlineFlex : CSSValueFlex); + } I'll take this. Created attachment 429513 [details]
Patch
Committed r277949 (238076@main): <https://commits.webkit.org/238076@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429513 [details]. |