Bug 224800

Summary:

REGRESSION (r275523): [iOS] Opaque system fill colors are incorrect in dark mode

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+
Patch for landing	none

Description Aditya Keerthi 2021-04-19 20:43:15 PDT

The colors are much lighter than expected.

Comment 1 Radar WebKit Bug Importer 2021-04-19 20:43:46 PDT

<rdar://problem/76878335>

Comment 2 Aditya Keerthi 2021-04-19 20:55:32 PDT

Created attachment 426516 [details]
Patch

Comment 3 Darin Adler 2021-04-19 21:35:44 PDT

Comment on attachment 426516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426516&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1343
> +            if (useDarkAppearance)
> +                return blendSourceOver(Color::black, systemColor);
> +            else
> +                return blendSourceOver(Color::white, systemColor);

This is one of those cases where ?: looks better:

    return blendSourceOver(useDarkAppearance ? Color::black : Color::white, systemColor);

Comment 4 Aditya Keerthi 2021-04-20 06:26:44 PDT

Created attachment 426542 [details]
Patch for landing

Comment 5 Aditya Keerthi 2021-04-20 06:28:25 PDT

Thanks for the review!

Comment 6 EWS 2021-04-20 09:16:52 PDT

Committed r276307 (236789@main): <https://commits.webkit.org/236789@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426542 [details].