Bug 224794

Summary:

[iOS][FCR] Update date/time picker appearance

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	wenson_hsieh: review+
Patch for landing	none

Description Aditya Keerthi 2021-04-19 18:44:30 PDT

...

Comment 1 Aditya Keerthi 2021-04-19 18:44:48 PDT

<rdar://problem/76785859>

Comment 2 Aditya Keerthi 2021-04-19 18:53:39 PDT

Created attachment 426505 [details]
Patch

Comment 3 Aditya Keerthi 2021-04-19 19:14:13 PDT

Created attachment 426508 [details]
Patch

Comment 4 Wenson Hsieh 2021-04-20 14:25:59 PDT

Comment on attachment 426508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=426508&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8382
> +    RetainPtr<UITargetedPreview> targetedPreview = createFallbackTargetedPreview(self, self.containerForContextMenuHintPreviews, _focusedElementInformation.interactionRect, backgroundColor);

Nit - `auto`.

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:71
> +- (instancetype)initWithDelegate:(id<WKDateTimePickerViewControllerDelegate>)delegate

Nit - space between `id` and `<`.

(AFAIK, the rule we typically follow is space before protocols, but no space before concrete types like in `NSArray<Foo *> *`).

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:94
> +    RetainPtr<UIVisualEffectView> backgroundView = adoptNS([[UIVisualEffectView alloc] initWithEffect:[UIBlurEffect effectWithStyle:UIBlurEffectStyleSystemMaterial]]);

Nit - `auto`

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:110
> +    RetainPtr<UIView> toolbarView = adoptNS([[UIView alloc] init]);

Nit - `auto`

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:121
> +    RetainPtr<UIView> separatorView = adoptNS([[UIView alloc] init]);

(Ditto)

> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:524
> +    [_view updateFocusedElementValueAsNumber:([date timeIntervalSince1970] + [self _timeZoneOffsetFromGMT:date]) * kMillisecondsPerSecond];

Nit - `date.timeIntervalSince1970`

Comment 5 Aditya Keerthi 2021-04-20 14:52:08 PDT

Created attachment 426597 [details]
Patch for landing

Comment 6 EWS 2021-04-20 15:45:22 PDT

Committed r276325 (236805@main): <https://commits.webkit.org/236805@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426597 [details].