Summary: | [Win] GetDoubleClickTime() returns 0 in the non-interactive window station on Windows 10 version 2004 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, don.olmstead, lingcherd_ho, pvollan, ross.kirsling, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Fujii Hironori
2021-04-19 18:39:03 PDT
Because AppleWin marks all editing/selection as flaky, it's not easy to observe this issue. But, AppleWin also has this issue. > editing/selection/ [ Pass Failure ] https://github.com/WebKit/WebKit/blob/a13091fa25bc02a82063ea6cfb65faae6ed8006a/LayoutTests/platform/win/TestExpectations#L1229 Created attachment 426641 [details]
WIP patch
GetDoubleClickTime() returns 0 in the window station.
SetDoubleClickTime also fails in the window station. GetLastError() returns ERROR_REQUIRES_INTERACTIVE_WINDOWSTATION. winapi - GetDoubleClickTime returns 0 unexpectedly - Stack Overflow https://stackoverflow.com/q/63466907 Bug in Windows 10 Version 2004: GetDoubleClickTime unexpectedly returns 0 when Batch Login is used | Wolfsbeeren https://www.neunbeere.de/blog/2020/08/bug-in-windows-10-version-2004-getdoubleclicktime-unexpectedly-returns-0-when-batch-login-is-used/ Created attachment 426654 [details]
Patch
Comment on attachment 426654 [details]
Patch
WebEventFactory.cpp also calls GetDoubleClickTime.
This should be put into a shared function and used by both.
Created attachment 426765 [details]
Patch
Comment on attachment 426765 [details] Patch Clearing flags on attachment: 426765 Committed r276421 (236886@main): <https://commits.webkit.org/236886@main> All reviewed patches have been landed. Closing bug. |