| Summary: | Rename FloatQuad::isEmpty() to boundingBoxIsEmpty() and reimplement isEmpty() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, joepeck, lingcherd_ho, megan_gardner, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2021-04-19 10:28:16 PDT
Created attachment 426462 [details]
Patch
Comment on attachment 426462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426462&action=review > Source/WebCore/platform/graphics/FloatQuad.h:-80 > - // isEmpty tests that the bounding box is empty. This will not identify > - // "slanted" empty quads. Maybe you want to leave the comment to explain the difference? The names are pretty good, but it didn't really click till I saw " "slanted" empty quads". Comment on attachment 426462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426462&action=review Thanks for the review! >> Source/WebCore/platform/graphics/FloatQuad.h:-80 >> - // "slanted" empty quads. > > Maybe you want to leave the comment to explain the difference? The names are pretty good, but it didn't really click till I saw " "slanted" empty quads". Makes sense — I'll keep the comment, as `// This method will not identify "slanted" empty quads.` Created attachment 426466 [details]
For landing
Committed r276275 (236757@main): <https://commits.webkit.org/236757@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426466 [details]. |