Bug 224769

Summary: Rename FloatQuad::isEmpty() to boundingBoxIsEmpty() and reimplement isEmpty()
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, joepeck, lingcherd_ho, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For landing none

Wenson Hsieh
Reported 2021-04-19 10:28:16 PDT
.
Attachments
Patch (9.39 KB, patch)
2021-04-19 12:34 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For landing (9.45 KB, patch)
2021-04-19 13:08 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-04-19 12:34:20 PDT
Created attachment 426462 [details] Patch
Tim Horton
Comment 2 2021-04-19 13:01:44 PDT
Comment on attachment 426462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426462&action=review > Source/WebCore/platform/graphics/FloatQuad.h:-80 > - // isEmpty tests that the bounding box is empty. This will not identify > - // "slanted" empty quads. Maybe you want to leave the comment to explain the difference? The names are pretty good, but it didn't really click till I saw " "slanted" empty quads".
Wenson Hsieh
Comment 3 2021-04-19 13:03:32 PDT
Comment on attachment 426462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426462&action=review Thanks for the review! >> Source/WebCore/platform/graphics/FloatQuad.h:-80 >> - // "slanted" empty quads. > > Maybe you want to leave the comment to explain the difference? The names are pretty good, but it didn't really click till I saw " "slanted" empty quads". Makes sense — I'll keep the comment, as `// This method will not identify "slanted" empty quads.`
Wenson Hsieh
Comment 4 2021-04-19 13:08:57 PDT
Created attachment 426466 [details] For landing
EWS
Comment 5 2021-04-19 15:21:02 PDT
Committed r276275 (236757@main): <https://commits.webkit.org/236757@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426466 [details].
Ling Ho
Comment 6 2021-04-23 02:59:23 PDT
rdar://76880824
Note You need to log in before you can comment on or make changes to this bug.