Summary: | Separated models don't get opacity set on them at all | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, kondapallykalyan, lingcherd_ho, philipj, sergio, simon.fraser, thorton, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2021-04-19 08:56:31 PDT
Created attachment 426428 [details]
Patch
Created attachment 426464 [details]
Patch
Created attachment 426480 [details]
Patch
Created attachment 426564 [details]
Patch
Now with tests! Comment on attachment 426564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426564&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3946 > + if (&layer == m_contentsLayer.get()) { I love this. > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3987 > + if (flags.contains(PlatformLayerTreeAsTextFlags::IncludeOpacity)) It is probably overkill to add a flag for opacity, just only dump it if it's non-1? But this is fine too. > LayoutTests/model-element/model-element-graphics-layers.html:22 > + model.remove(); subtle and hilarious. someday we should really debug this. Comment on attachment 426564 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426564&action=review >> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3987 >> + if (flags.contains(PlatformLayerTreeAsTextFlags::IncludeOpacity)) > > It is probably overkill to add a flag for opacity, just only dump it if it's non-1? But this is fine too. Agree Committed r276327 (236807@main): <https://commits.webkit.org/236807@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426564 [details]. For future historians, the removal of the model was not actually necessary. All we really needed to do was fix the </p> to be </pre>. |